fix: returning comparable error on contex's cancelled errorcase #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Module version update from v2 to v3, * Go version dep updated from 1.20 to 1.24, * Added stub record for migration guide.
Add support for `go-option` to the `arrow`, `datetime`, `decimal`, and `uuid` packages. This allows for handling optional values of the `Arrow`, `Datetime`, `Interval`, `Decimal`, `UUID` and `BoxError` types. The following changes have been made: - Added `go:generate` directives to the `Arrow`, `Datetime`, `Interval`, `Decimal`, `UUID` and `BoxError` types to generate optional types using `github.com/tarantool/go-option/cmd/gentypes`. - Implemented `MarshalMsgpack` and `UnmarshalMsgpack` methods for the `Arrow`, `Datetime`, `Interval`, and `Decimal` types. - Added `marshalUUID` and `unmarshalUUID` functions for the `UUID` type. - The generated `_gen.go` files contain the `Optional*` types that wrap the original types and provide methods to handle optional values, including `EncodeMsgpack` and `DecodeMsgpack` for `msgpack` serialization. - Refactored the `datetime` and `decimal` decoders to use the new `UnmarshalMsgpack` methods.
ermyar
force-pushed
the
ermyar/gh-457_cancelled_ctx_error
branch
from
35999b5 to
99a30a9
Compare
Revised error use, added new type CodeErrors to compare them using errors.Is(). Also used to check that request's ctx was cancelled. Fixes (#457)
ermyar
force-pushed
the
ermyar/gh-457_cancelled_ctx_error
branch
from
99a30a9 to
6b1bbe6
Compare
oleg-jukovec
changed the title
Collaborator
|
Please, change the base branch to |
oleg-jukovec
requested changes
Oct 27, 2025
Collaborator
oleg-jukovec
left a comment
oleg-jukovec
left a comment
There was a problem hiding this comment.
Please, add support of ability to unwrap/compare an original context error instead of the code.
We should have an entry in the CHANGELOG.md for the change too.
| // Output: | ||
| // Ping Resp data [] | ||
| // Ping Error context is done (request ID N) | ||
| // Ping Error context is done (request ID N) (NxN) |
Collaborator
There was a problem hiding this comment.
The format above should replace only the request ID, please fix the replace pattern.
Suggested change
| // Ping Error context is done (request ID N) (NxN) | |
| // Ping Error context is done (request ID N) (0x4008) |
| if !contextDoneErrRegexp.Match([]byte(err.Error())) { | ||
| t.Fatalf("Failed to catch an error from done context") | ||
| } | ||
| // checking that we could use errors.Is to get known about error. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // checking that we could use errors.Is to get known about error. | |
| // Checking that we could use errors.Is to get known about error. |
| t.Fatalf("Failed to catch an error from done context") | ||
| } | ||
| // checking that we could use errors.Is to get known about error. | ||
| require.True(t, errors.Is(err, ErrCancelledCtx)) |
Collaborator
There was a problem hiding this comment.
The problem of the approach - we unable to get an original context error here. But we should.
Suggested change
| require.True(t, errors.Is(err, ErrCancelledCtx)) | |
| require.True(t, errors.Is(err, ErrCancelledCtx)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised error using, added new type CodeErrors to compare them using errors.Is(). Also used to check that request's ctx was cancelled. Also updated state CodeErrors.
Fixes (#457)
I didn't forget about (remove if it is not applicable):
Related issues: (#457)